search

cisco / ChezScheme

Chez Scheme
Apache License 2.0
6.97k stars 984 forks source link

cp0: combine dropping a binding and `begin` rotation #796

Closed mflatt closed 8 months ago

mflatt commented 8 months ago

A follow-up to c081296367, this commit adjusts the cp0 change to prefer an existing case instead of the new one. This order still passes the new test, it passes old ones with a small adjustment, and it passes Racket tests that are similar to "cp0.ms" tests.

mflatt commented 8 months ago

Er... looking one more time, the new example suggests that the updated cp0 order is worse, not better! I'll take this from the top on the Racket test-suite side and figure out where I got confused.

mflatt commented 8 months ago

Trying again, this time with @owaddell's repair, a test that reflects the original issue for Racket, and a corrected version of the broken test that showed why my first attempt was bad.