search

cisco / cisco-network-puppet-module

Apache License 2.0
55 stars 68 forks source link

Transport class update work #551

Closed willmeek closed 5 years ago

willmeek commented 5 years ago

See https://github.com/cisco/cisco-network-puppet-module/pull/550 for main comment thread

This has been created to push a function to allow for pre-transports credentials to be maintained

(No push access to @david22swan repo and on PTO)

willmeek commented 5 years ago

cc @DavidS as the Transports expert :)

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@ee811fd). Click here to learn what that means. The diff coverage is 14.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #551   +/-   ##
=========================================
  Coverage           ?   5.79%           
=========================================
  Files              ?     177           
  Lines              ?   20924           
  Branches           ?       0           
=========================================
  Hits               ?    1212           
  Misses             ?   19712           
  Partials           ?       0
Impacted Files Coverage Δ
lib/puppet_x/cisco_nexus/transport_shim.rb 0% <0%> (ø)
lib/puppet/transport/schema/cisco_nexus.rb 100% <100%> (ø)
...b/puppet/util/network_device/cisco_nexus/device.rb 54.16% <52.17%> (ø)
lib/puppet/transport/cisco_nexus.rb 95% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee811fd...659206a. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@ee811fd). Click here to learn what that means. The diff coverage is 14.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #551   +/-   ##
=========================================
  Coverage           ?   5.79%           
=========================================
  Files              ?     177           
  Lines              ?   20924           
  Branches           ?       0           
=========================================
  Hits               ?    1212           
  Misses             ?   19712           
  Partials           ?       0
Impacted Files Coverage Δ
lib/puppet_x/cisco_nexus/transport_shim.rb 0% <0%> (ø)
lib/puppet/transport/schema/cisco_nexus.rb 100% <100%> (ø)
...b/puppet/util/network_device/cisco_nexus/device.rb 54.16% <52.17%> (ø)
lib/puppet/transport/cisco_nexus.rb 95% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee811fd...1fa1be9. Read the comment docs.

willmeek commented 5 years ago

550 has been updated with the commit