Closed eckelcu closed 5 years ago
Thanks for adding the NOTICE file. It would be best if you added the project name as the first line of the NOTICE file to clarify what the copyright statement covers. This will become more important if/when you add attribution for any dependencies in this NOTICE file.
@eckelcu Done.
https://github.com/cisco/cisco-network-puppet-module/blob/develop/NOTICE
I am going to close this PR now.
Great, Mike. Thanks for adding.
Cheers, Charles
From: Mike Wiebe notifications@github.com Reply-To: cisco/cisco-network-puppet-module reply@reply.github.com Date: Monday, June 17, 2019 at 5:46 PM To: cisco/cisco-network-puppet-module cisco-network-puppet-module@noreply.github.com Cc: Charles Eckel eckelcu@cisco.com, Mention mention@noreply.github.com Subject: Re: [cisco/cisco-network-puppet-module] Create NOTICE (#554)
@eckelcuhttps://github.com/eckelcu Done.
https://github.com/cisco/cisco-network-puppet-module/blob/develop/NOTICE
I am going to close this PR now.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cisco/cisco-network-puppet-module/pull/554?email_source=notifications&email_token=ABPVRPQ5YHJQJROSJFRDZHTP26PQTA5CNFSM4HV66Q72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3MXXI#issuecomment-502713309, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABPVRPSTZXUPEXR5TNGSF2DP26PQTANCNFSM4HV66Q7Q.
@eckelcu Hi Charles. We already added a
NOTICE
file a few days ago. See the following.https://github.com/cisco/cisco-network-puppet-module/blob/develop/NOTICE