search

cisco / cisco-network-puppet-module

Apache License 2.0
55 stars 68 forks source link

cisco_interface_ospf: flush should use single_intf param for new instance #568

Closed chrisvanheuveln closed 5 years ago

chrisvanheuveln commented 5 years ago

The flush method incisco_interface_ospf needs to populate the single_intf param when calling NU InterfaceOspf.new. I had actually coded this earlier for the performance fixes but somehow lost this change at PR time. The NU object will still be created even without this change but by including the single_intf value it allows Interface.interfaces to do a single interface lookup instead of querying for all interfaces.

codecov-io commented 5 years ago

Codecov Report

Merging #568 into develop will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #568      +/-   ##
==========================================
- Coverage      5.8%    5.8%   -0.01%     
==========================================
  Files          177     177              
  Lines        20876   20878       +2     
==========================================
  Hits          1212    1212              
- Misses       19664   19666       +2
Impacted Files Coverage Δ
lib/puppet/provider/cisco_interface_ospf/cisco.rb 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4aedd5...7702b69. Read the comment docs.