cisco / cisco-network-puppet-module

Apache License 2.0
55 stars 68 forks source link

Add vlan property to unprops for I2 images #570

Closed mikewiebe closed 5 years ago

mikewiebe commented 5 years ago

The vlan property for the cisco_acl provider is not supported on 7.0(3)I2(x) images.

Tested on:

7.0(3)I2 Image

n9k(config-acl)# 40 deny icmp any any time-exceeded dscp af12 ?
  <CR>                  
  packet-length         Match packets based on layer 3 packet length
  redirect              Redirect to interface(s). Syntax example: redirect Ethernet1/1,Ethernet1/2,port-channel1
  set-erspan-dscp       Syntax: set-erspan-dscp; Set ERSPAN outer IP DSCP value <0-63>
  set-erspan-gre-proto  Syntax: set-erspan-gre-proto; Set ERSPAN GRE protocol <0-65535>
  time-range            Specify a time range
  log                   Log matches against this entry

n9k(config-acl)# 40 deny icmp any any time-exceeded dscp af12 ^C

7.0(3)I7 Image

n9k(config-acl)# 40 deny icmp any any time-exceeded dscp af12 ?
  <CR>                  
  packet-length         Match packets based on layer 3 packet length
  redirect              Redirect to interface(s). Syntax example: redirect Ethernet1/1,Ethernet1/2,port-channel1
  set-erspan-dscp       Syntax: set-erspan-dscp; Set ERSPAN outer IP DSCP value <1-63>
  set-erspan-gre-proto  Syntax: set-erspan-gre-proto; Set ERSPAN GRE protocol <1-65535>
  time-range            Specify a time range
  vlan                  Configure match based on vlan   <-------------- Supported here
  log                   Log matches against this entry

n9k(config-acl)# 40 deny icmp any any time-exceeded dscp af12 redirect ?
codecov-io commented 5 years ago

Codecov Report

Merging #570 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #570   +/-   ##
=======================================
  Coverage      5.8%    5.8%           
=======================================
  Files          177     177           
  Lines        20878   20878           
=======================================
  Hits          1212    1212           
  Misses       19666   19666

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c54081...0ae3478. Read the comment docs.

chrisvanheuveln commented 5 years ago

👍