search

cisco / cisco-network-puppet-module

Apache License 2.0
55 stars 68 forks source link

Move threshold logic into cmnutils #572

Closed chrisvanheuveln closed 5 years ago

chrisvanheuveln commented 5 years ago

Tested on n9k-108/GS and n6k-77/Agtless.

chrisvanheuveln commented 5 years ago

Hold off on review... WIP.

chrisvanheuveln commented 5 years ago

okay, review it!

codecov-io commented 5 years ago

Codecov Report

Merging #572 into develop will increase coverage by 0.05%. The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #572      +/-   ##
==========================================
+ Coverage      5.8%   5.85%   +0.05%     
==========================================
  Files          177     177              
  Lines        20878   20876       -2     
==========================================
+ Hits          1212    1223      +11     
+ Misses       19666   19653      -13
Impacted Files Coverage Δ
lib/puppet/provider/cisco_interface/cisco.rb 0% <0%> (ø) :arrow_up:
lib/puppet/provider/cisco_interface_ospf/cisco.rb 0% <0%> (ø) :arrow_up:
...et/provider/cisco_interface_channel_group/cisco.rb 0% <0%> (ø) :arrow_up:
...t/provider/cisco_interface_evpn_multisite/cisco.rb 0% <0%> (ø) :arrow_up:
lib/facter/cisco_nexus.rb 92.85% <75%> (-7.15%) :arrow_down:
lib/puppet_x/cisco/cmnutils.rb 23.03% <9.09%> (-1%) :arrow_down:
lib/puppet/transport/cisco_nexus.rb 100% <0%> (+5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19303c4...db12390. Read the comment docs.