search

cisco / elsy

An opinionated, multi-language, build tool based on Docker and Docker Compose
Apache License 2.0
79 stars 22 forks source link

lc bootstrap no longer hiding confusing log messages for docker versions > 1.12.6 #78

Closed paulcichonski closed 7 years ago

paulcichonski commented 7 years ago

When running lc bootstrap on repos using newer versions of docker versions > 1.12.6 you will see these confusing log messages again, because docker changed their log format...again.

404 Client Error: Not Found ("repository <repo-image-name> not found: does not exist or no pull access")

I've confirmed the above on 17.06.2-ce, but I think this applies to 1.13.x too.

paulcichonski commented 7 years ago

This bbt describes why we hide these log lines: https://github.com/cisco/elsy/blob/master/blackbox-test/features/bootstrap.feature#L77-L97 .

paulcichonski commented 7 years ago

We may want to fix this by just getting smarter about what we pull at https://github.com/cisco/elsy/blob/master/command/bootstrap.go#L35. It shouldn't be that hard to just filter that list of services down to include everything, but the image defined in the lc.yml docker_image_name field.