search

cisco / elsy

An opinionated, multi-language, build tool based on Docker and Docker Compose
Apache License 2.0
79 stars 22 forks source link

Fix package command for complex Dockerfiles #98

Closed munkyboy closed 5 years ago

munkyboy commented 5 years ago

bah, my --pull change breaks this test/use-case:

  Scenario: with a docker artifact based on a local image
    Given a file named "Dockerfile" with:
    """
    FROM elsyblackbox_docker_artifact
    """
    And a file named "lc.yml" with:
    """yaml
    name: testpackage
    """
    When I run `lc package --docker-image-name=elsyblackbox_docker_artifact`
    Then it should succeed with "Successfully built "

I think relying on local images like this is an anti-pattern and we should drop support for it. Thoughts?

paulcichonski commented 5 years ago

I can't remember why we even had that test?

munkyboy commented 5 years ago

That old test was to support that exact case. Some project relied on using an image build earlier probably in the lc bootstrap phase.

munkyboy commented 5 years ago

fixed up the PR to explicitly remove support for building from local images

paulcichonski commented 5 years ago

If we are removing support for something the version bump should be 5.0.0.

munkyboy commented 5 years ago

I did. 247a5d4

paulcichonski commented 5 years ago

ah, right, but the commit message is still "release v4.3.0"

munkyboy commented 5 years ago

yeah, I plan to rewrite when I squash