search

cisco / go-hpke

Implementation of draft-irtf-cfrg-hpke
BSD 2-Clause "Simplified" License
30 stars 15 forks source link

Align with pending -07 changes #49

Closed chris-wood closed 3 years ago

chris-wood commented 3 years ago

This updates to the pending -07 changes. A diff between the editor's copy and draft -06 can be found here. The corresponding draft update is here.

Before merging, I'd like to hear from @rozbb, @dmcardle, @kjacobs-moz, @jedisct1, and @armfazh to confirm that the test vectors match.

cc @blipp, too!

kjacobs-moz commented 3 years ago

After changing the draft label from "HPKE-06" to "HPKE-07", the vectors* in https://github.com/cfrg/draft-irtf-cfrg-hpke/pull/195 pass in NSS.

* Tested only Base and PSK modes, DHKEM(X25519, HKDF-SHA256), HKDF-SHA256, [AES-128-GCM, ChaCha20Poly1305]. I've not added support for Export-Only AEAD.

chris-wood commented 3 years ago

@kjacobs-moz I updated those vectors to include more encryptions (up to a sequence number of 256). Can you please confirm the new vectors pass for you? (Sorry for the trouble!)

rozbb commented 3 years ago

Yup, all good