cisco / joy

A package for capturing and analyzing network flow data and intraflow data, for network research, forensics, and security monitoring.
Other
1.31k stars 329 forks source link

update copyright notice #207

Closed eckelcu closed 5 years ago

eckelcu commented 6 years ago

The "All rights reserved." should be removed because this repo is being licensed under the terms of the BSD license, not reserving all rights.

bhudson33 commented 5 years ago

We do not believe we need to remove the "All rights reserved" line from the license.

When you do some work, the default copyright position is all rights reserved. Nobody can do anything with your work without your express permission, or a license to do so. The BSD license is your license to other people, to make it clear what they can do. However, any rights not explicitly granted by the BSD license are still reserved by you. Since the default position is all rights reserved, it's not strictly necessary to add that to a copyright notice - but it does make it clearer, and can help avoid scenarios where someone uses your work illegally. By having the all rights reserved notice, and then a license, you're affirming it's your work and your rights, but you allow people to do these specific things with it.

Also for more reference, please refer to the following: https://github.com/github/choosealicense.com/issues/556 https://en.wikipedia.org/wiki/BSD_licenses

eckelcu commented 5 years ago

Interesting, and thanks for sharing. I have not come this practice before. Other licenses descriptions in Wikipedia and elsewhere do not do this.

https://en.wikipedia.org/wiki/MIT_License https://www.apache.org/licenses/LICENSE-2.0 https://www.gnu.org/licenses/gpl-3.0.en.html

I still believe it is better to remove this statement, because it can be seen as conflicting with the terms of the license, but I leave it up to you.

Cheers, Charles

From: bhudson33 notifications@github.com Reply-To: cisco/joy reply@reply.github.com Date: Wednesday, November 14, 2018 at 7:44 AM To: cisco/joy joy@noreply.github.com Cc: Charles Eckel eckelcu@cisco.com, Author author@noreply.github.com Subject: Re: [cisco/joy] update copyright notice (#207)

We do not believe we need to remove the "All rights reserved" line from the license.

When you do some work, the default copyright position is all rights reserved. Nobody can do anything with your work without your express permission, or a license to do so. The BSD license is your license to other people, to make it clear what they can do. However, any rights not explicitly granted by the BSD license are still reserved by you. Since the default position is all rights reserved, it's not strictly necessary to add that to a copyright notice - but it does make it clearer, and can help avoid scenarios where someone uses your work illegally. By having the all rights reserved notice, and then a license, you're affirming it's your work and your rights, but you allow people to do these specific things with it.

Also for more reference, please refer to the following: github/choosealicense.com#556https://github.com/github/choosealicense.com/issues/556 https://en.wikipedia.org/wiki/BSD_licenses

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cisco/joy/pull/207#issuecomment-438708655, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF9Yvnc9lGgadj60n5yGJKB92P_B_cHrks5uvDpugaJpZM4YMw2L.