search

cisco / libacvp

The libacvp library is a client-side implementation of the draft ACVP protocol (github.com/usnistgov/ACVP).
Apache License 2.0
67 stars 69 forks source link

Addition for AES-FPE and Update to DSA #847

Closed RandallSteck closed 2 months ago

RandallSteck commented 3 months ago

Two commits -- Add tgId and tcId values to all DSA TCs Add support for AES-FF1 and AES-FF3

AES was validated for Demo vectors against the following library: https://github.com/mysto/clang-fpe

abkarcher commented 3 months ago

Hello,

Thanks for the contribution. Getting a build error for missing FF!/FF3 revision values. Also, are the new pointers in the cap obj and TC structures both being freed?

Thanks, Andrew

RandallSteck commented 3 months ago

1) I've added the revision identifiers to acvp_lcl.h 2) Memory for tc is freed in acvp_aes.c:~1641 3) I've patched the capabilities to free memory

All good findsl!

RandallSteck commented 2 months ago

Bump for attention. I have other code to contribute, but I don't want to muddle the commits.

abkarcher commented 2 months ago

Thanks for resolving all of that. Will look in the next day or two; apologies for the wait, a lot of dev work going on 😄

abkarcher commented 2 months ago

Everything seems to be working well, thanks!