search

cisco / libacvp

The libacvp library is a client-side implementation of the draft ACVP protocol (github.com/usnistgov/ACVP).
Apache License 2.0
67 stars 69 forks source link

Fix ECDSA in FIPS 186-5 #866

Closed iomartin closed 1 month ago

iomartin commented 1 month ago

Several curves and hashes were missing for ECDSA in FIPS 186-5.

Also included two smaller changes in this PR, one to .gitignore and one that shows failed algorithms more clearly.

abkarcher commented 1 month ago

Hello,

Just some extra info - The 186-5 flag was not originally intended to be compiled as much as it was to be an example for people who were needing to reference it for their own modules. The flag will be removed for the 2.2.0 release, as we have refactored the app to separate all the registrations.

Still, I am happy to accept this PR for the imminent 2.1.2 release as long as it doesn't change the capabilities registration for non 186-5 modules (e.g. existing OpenSSL FPs < 3.1.2). Could you re-open it against the 2_1_0-throttle branch?

Thanks, Andrew

iomartin commented 1 month ago

Thanks for reviewing and the extra info.

I have reopened this as #867 based on the 2_1_0-throttle branch