search

cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.23k stars 476 forks source link

Make it easy to use lib in VS2012 #449

Closed Jopie64 closed 5 years ago

Jopie64 commented 5 years ago

We needed to use this lib in a VC2012 project. I figured it would be a good idea to contribute the changes we made to accomplish this.

pabuhler commented 5 years ago

Hi, @Jopie64 thanks for the PR. The C89 changes look good and will likely merge them. When it comes to the cmake support I will just need to ensure that we would like the overhead of maintaining an extra build system. If the initial purpose is to replace the current visual studio projects then I think it is a good idea. @JonathanLennox & @nils-ohlmeier, you two have made the most recent changes to the visual studio support, what do you think?

nils-ohlmeier commented 5 years ago

I have only made changes to the visual studio project files to keep it working after/when merging the changes from Mozilla. When it comes to choosing a build system Mozilla is building libsrtp with it's own build system any way. So I would vote for what ever is easiest to maintain from the perspective of the project. Cmake is a reasonable choice, but might not be a good fit if nobody in the project can maintain it.

Jopie64 commented 5 years ago

If it's maintaining like, adding and removing some files, then I think by looking at the CMakeLists.txt file you can see that this is not too hard. Even for someone who never heard of it. Also you don't need Visual Studio/Windows to maintain it. Maybe this could weigh in the decision whether or not to replace the VS files with it.

pabuhler commented 5 years ago

I think like @nils-ohlmeier said most people have there own build system for libSRTP when integrating into project. Replacing the current visual studio project files with a cmake solution sounds like a good idea to me. When can just add it for now and then remove the visual studio project files after the next release.