search

cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.23k stars 476 forks source link

cmake support #455

Closed pabuhler closed 5 years ago

pabuhler commented 5 years ago

This extends the cmake support added in #449. It now enables cmake to be used cross platform and supports openssl and debug config options. The idea is to support cmake as a complete alternative build system, replacing the checked in windows project files (#450).

cmake builds have been added to travis, including on windows. The ENABLE_OPENSSL option is also supported on windows but I did not manage to get travis to install openssl.

I am not a cmake expert so I am sure there are better ways of handling things but this is a start.

nils-ohlmeier commented 5 years ago

LGTM as well. I might also be able to add similar support for NSS as well later.

pabuhler commented 5 years ago

@nils-ohlmeier did not mean to offend anyone with skipping nss support initially :) just wanted to check that I could getting openssl working first. If you feel like adding nss support after that would be great!

kyleung-broadsoft commented 5 years ago

It worked fine on Windows with OPENSSL enabled and custom OPENSSL directory to generate Visual Studio solution file and nmake makefile.

nils-ohlmeier commented 5 years ago

@nils-ohlmeier did not mean to offend anyone with skipping nss support initially :) just wanted to check that I could getting openssl working first. If you feel like adding nss support after that would be great!

No offense taken. Since the Firefox builds uses it's own build system it's totally Ok to merge this without NSS support. And I can look into adding NSS later in a follow up PR.