search

cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.22k stars 475 forks source link

Memory Leak #480

Closed QiAnXinCodeSafe closed 4 years ago

QiAnXinCodeSafe commented 4 years ago

Memory is allocated

https://github.com/cisco/libsrtp/blob/3ef1d8f323a6d2679a4754a543f232357eb0f102/test/rtp_decoder.c#L272

but at the end of function，never free it

pabuhler commented 4 years ago

Hi, thanks

I think the answer here is that the input_key should never be allocated, it should either point at the key argument from "-k" or be null and generate an error if not set. What do you think?

QiAnXinCodeSafe commented 4 years ago

agree