search

cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.2k stars 472 forks source link

use nss based hmac when nss enabled #520

Closed pabuhler closed 3 years ago

pabuhler commented 3 years ago

This was a missing part of the nss support.

Disable sha1_driver if USE_EXTERNAL_CRYPTO is enabled. The sha1_driver is used to test internal sha1 implementation but that is only used when there is no external hmac implementation.

pabuhler commented 3 years ago

I have merged this now, the intention of this PR was to add the missing hmac support for NSS. If the entire NSS code can/should be refactored or cleaned up then perhaps there should be an issues created based off the discussion here. It would be best if it was driven by some one familiar with NSS or that actively uses the NSS backend.