search

cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.2k stars 472 forks source link

applications wanting to use srtp_hdr_t and other things from private headers #532

Closed dpocock closed 1 year ago

dpocock commented 3 years ago

There are at least two applications who want to use bits of srtp_priv.h and friends.

reSIProcate tries to use srtp_hdr_t in one of the unit tests, it works with an embedded copy of libsrtp but it doesn't work when using libsrtp2-dev packages because the package maintainers refuse to distribute private headers.

Trying to build qtwebengine on Debian https://bugs.debian.org/866784

Trying to build unit tests for reSIProcate reflow/dtls_wrapper/test https://www.resiprocate.org/bugzilla/show_bug.cgi?id=169

paulej commented 3 years ago

srtp_hdr_t is a structure that represents an RTP header. It's not specific to SRTP, really. Why not just reproduce that if it's for testing purposes only? There is no risk of the RTP header changing in libsrtp since it's defined in RFC 3550, not RFC 3711. Are the other dependencies like that?

pabuhler commented 3 years ago

@dpocock I tried to follow the links but now where was there an explanation as to why these projects need srtp_hdr_t. Like Paul mentioned this just a generic RTP header structure and is not part of the libSRTP api. My suggestion would be for these projects to remove / change there use of this structure or come with a very compelling argument as to why libSRTP should maintain a public version of this structure just for the use of a few other projects.

JeremySigler commented 2 years ago

Merging would not work in this instance.too much damage.

pabuhler commented 1 year ago

I am going to close this as it should not be used outside of library code.