Improve OpenSSL KDF check

cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)

Other

1.2k stars 472 forks source link

Improve OpenSSL KDF check #546

Closed nazar-pc closed 3 years ago

nazar-pc commented 3 years ago

Without this change libsrtp2 usage with OpenSSL as subproject will fail with:

subprojects/libsrtp2/meson.build:134:10: ERROR: Dependencies must be external dependencies

I had to include 2 additional conditions:

make sure dependency is not internal, otherwise we know cc.has_function() will fail as error above suggests
check if user explicitly disabled crypto-library-kdf option (in which case there is no need to check anything and configuration incorrectly didn't take that into account)

P.S. OpenSSL as subproject/wrap will hopefully soon be a thing, see https://github.com/mesonbuild/wrapdb/pull/113

nazar-pc commented 3 years ago

Can someone review this, please? It is a pretty trivial, but also important change

paulej commented 3 years ago

Looks beautiful, but does it work? I have no idea. Who is the Meson expert?

nazar-pc commented 3 years ago

@tp-m can you confirm this looks good to you?

As to whether it works, it definitely does in https://github.com/versatica/mediasoup/pull/622 where CI runs on Windows, Linux and macOS with various compilers and all builds/runs fine. And there is really nothing so significant here to break anything.

tp-m commented 3 years ago

@tp-m can you confirm this looks good to you?

Yes, looks good to me.

Looking forward to be able to use this in GStreamer as well!

pabuhler commented 3 years ago

OpenSSL KDF check should probably be removed, I do not know of any actual use of OpenSSL KDF with libSRTP but that is a different issue.