Closed paulej closed 3 years ago
That might change a lot of lines. I just wanted to fix the whitespace, which doesn't look so disruptive. Also, that won't work on .md and .css files.
-------- Original Message -------- From: Richard Barnes @.> Sent: August 15, 2021 12:45:40 AM EDT To: cisco/libsrtp @.> Cc: "Paul E. Jones" @.>, Author @.> Subject: Re: [cisco/libsrtp] Remove tabs, fix typos, etc. (#552)
Shouldn’t this just apply clang-format?
On Sat, Aug 14, 2021 at 14:57 Paul E. Jones @.***> wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/cisco/libsrtp/pull/552 Commit Summary
- Remove tabs, fix typos, etc.
File Changes
- M LICENSE https://github.com/cisco/libsrtp/pull/552/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7 (12)
- M README.md https://github.com/cisco/libsrtp/pull/552/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 (12)
- M cmake/FindMbedTLS.cmake https://github.com/cisco/libsrtp/pull/552/files#diff-44985aeb33c364cd8b246e7246d2cf35c803069ecfa5facaa29f08af18381a4d (2)
- M crypto/cipher/aes_gcm_mbedtls.c https://github.com/cisco/libsrtp/pull/552/files#diff-225ece968acd6ed1bc2727f0671cede6de5313d9f0e2e97bfcd6938e66523fff (24)
- M crypto/cipher/aes_gcm_nss.c https://github.com/cisco/libsrtp/pull/552/files#diff-c54488027e23fabd3e5b769f75fed391f12328d5f06719a5053f82564f786190 (24)
- M crypto/cipher/aes_gcm_ossl.c https://github.com/cisco/libsrtp/pull/552/files#diff-bbd94e8876b29cf6ab6507088cf5dddeeac531aa6d3f69e41c3716ce5a3c0bb5 (24)
- M crypto/cipher/aes_icm.c https://github.com/cisco/libsrtp/pull/552/files#diff-7711e18e2249d0a25a0325e1099c1d07d744a7a0bf78598eafff9138b7638f35 (10)
- M crypto/cipher/aes_icm_mbedtls.c https://github.com/cisco/libsrtp/pull/552/files#diff-a333be3d5567935187b2a3dd64386fff628148897cc146e29ac9b26737855064 (6)
- M crypto/cipher/aes_icm_nss.c https://github.com/cisco/libsrtp/pull/552/files#diff-9f9c87769668aa2cf4936b5dd6223d8727da025be04f78409a54b16934455048 (6)
- M crypto/cipher/aes_icm_ossl.c https://github.com/cisco/libsrtp/pull/552/files#diff-4936d6c954d0c8b0d5783bbcb251eae967258aebdf23ae6c5c3331cdb3459993 (8)
- M crypto/test/cipher_driver.c https://github.com/cisco/libsrtp/pull/552/files#diff-9905c2cc3f0b59929ee6f994003289c8618ab294dff24252cae100dcd804c9e7 (4)
- M doc/docs.css https://github.com/cisco/libsrtp/pull/552/files#diff-486df55886fb261c01f4702c8f9dea57795290ecf7f454811d7a1add378caccb (1323)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cisco/libsrtp/pull/552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASOTJPUHTB3LAUI4Y425DT44GGHANCNFSM5CFTZNBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/cisco/libsrtp/pull/552#issuecomment-898994832
speaking of clang-format we should probably update the version in use.
@paulej have you run clang format after making the changes to source files ? I have added clang format as a git hub action now so if you rebase or merge from master the format check will run on this PR
@pabuhler No. I didn't want to create formatting changes that would look extensive. I just wanted to remove the inconsistent use of tabs.
Shouldn’t this just apply clang-format?
On Sat, Aug 14, 2021 at 14:57 Paul E. Jones @.***> wrote: