cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.2k stars 472 forks source link

Remove tabs, fix typos, etc. #552

Closed paulej closed 3 years ago

bifurcation commented 3 years ago

Shouldn’t this just apply clang-format?

On Sat, Aug 14, 2021 at 14:57 Paul E. Jones @.***> wrote:


You can view, comment on, or merge this pull request online at:

https://github.com/cisco/libsrtp/pull/552 Commit Summary

  • Remove tabs, fix typos, etc.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cisco/libsrtp/pull/552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASOTJPUHTB3LAUI4Y425DT44GGHANCNFSM5CFTZNBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

paulej commented 3 years ago

That might change a lot of lines. I just wanted to fix the whitespace, which doesn't look so disruptive. Also, that won't work on .md and .css files.

-------- Original Message -------- From: Richard Barnes @.> Sent: August 15, 2021 12:45:40 AM EDT To: cisco/libsrtp @.> Cc: "Paul E. Jones" @.>, Author @.> Subject: Re: [cisco/libsrtp] Remove tabs, fix typos, etc. (#552)

Shouldn’t this just apply clang-format?

On Sat, Aug 14, 2021 at 14:57 Paul E. Jones @.***> wrote:


You can view, comment on, or merge this pull request online at:

https://github.com/cisco/libsrtp/pull/552 Commit Summary

  • Remove tabs, fix typos, etc.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cisco/libsrtp/pull/552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASOTJPUHTB3LAUI4Y425DT44GGHANCNFSM5CFTZNBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/cisco/libsrtp/pull/552#issuecomment-898994832

pabuhler commented 3 years ago

speaking of clang-format we should probably update the version in use.

pabuhler commented 3 years ago

@paulej have you run clang format after making the changes to source files ? I have added clang format as a git hub action now so if you rebase or merge from master the format check will run on this PR

paulej commented 3 years ago

@pabuhler No. I didn't want to create formatting changes that would look extensive. I just wanted to remove the inconsistent use of tabs.