cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.2k stars 472 forks source link

Fix set ROC functionality with gcm #558

Closed pabuhler closed 2 years ago

pabuhler commented 2 years ago

The srtp_set_stream_roc() functionality does not work as expected with AEAD ciphers. The issue is that the internal protect & unprotect functions for AEAD duplicate some of the functionality from the standard protect & unprotect functions but did not get updated when srtp_set_stream_roc() was added. This PR just ensure the behavior is the same, ideally these functions should not be duplicating code.