Closed lanedis closed 2 years ago
@nirbheek @tp-m @xhaakon ?
This is correct, and I tested that it's broken before this and works with this patch applied. LGTM!
ps: also we can throw away
public_incs
and usesrtp2_incs
instead, not sure which one solution we should to prefer
Yeah, I think we can use srtp2_incs
here. That's cleaner.
I think this happened because the tests are not using libsrtp2_dep
, and are linking to the library directly, and adding include_directories:
manually. For extra points (and to ensure that this doesn't break in the future), we could switch the tests over to libsrtp2_dep
and libsrtp2_static_dep
(a new declare_dependency()
). But that can be done in a separate PR :)
This is only affects srtp as a meson subproject, if you compile and install it stand-alone everything works fine. test_main.c:
meson.build:
output:
This is because public_incs pointed to 'include/srtp2' instead of 'include' ps: also we can throw away
public_incs
and usesrtp2_incs
instead, not sure which one solution we should to prefer