search

cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.19k stars 472 forks source link

Update README.md to include NSS #574

Closed traud closed 2 years ago

traud commented 2 years ago

Furthermore, I changed the order to reflect the current order of ./configure -h.

Two notes:

  1. What about removing both ‘Location of’? They are auto-detected and required only if not the system provided library should be used. Actually, the switch for OpenSSL does not work for a current version of OpenSSL, when its was build in its source tree (there is no folder called /lib). Did not test NSS.
  2. What about adding a statement that either crypto library is used but none is leveraged on default. Some downstream maintainers like those on Debian, for example, did no enable OpenSSL for years. And now offer just NSS.
pabuhler commented 2 years ago

@traud thanks for the patch.

As to your first point we have also noticed that "location of" is not very useful for system installs and it is much better to use the auto detection. What it has been useful for is when having local builds of openssl when developing and debugging, and in these cases at least I have installed to a local prefix so the directory structure is as expected. If there is a better way to do this then we should definitely look into it. I think it all depends on the use case that is trying to be solved.

For the second point, I would almost say that openssl should be default on these days with NSS & internal as alternatives.

I think the best is to open issues for both of these to track it out side this PR. Hope that is ok.

traud commented 2 years ago

having local builds of openssl when developing and debugging […] installed to a local prefix

Yes, I did not know about that use case. The auto-detection does not find that automatically then, right? I am using the source-tree as path. However, I more and more realize that this seems to be an uncommon use-case. By chance, do you have a guide, tutorial or how-to explaining that at hand? Furthermore, some projects like libSRTP use an extra parameter for the path, others simply append it, for example, --enable-openssl[=path]. A pity that this is not standardized.

pabuhler commented 2 years ago

you mean how to build a local openssl and then build libsrtp using it ? If so I have some notes that I refer to and can dig them up.

I am not really a autotools kind of guy so try to make do with what was there from before and deffer to others alot. So if you have suggestions I am open to it, but bets when they are in the form of PR's ;-)