cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.19k stars 470 forks source link

meson.build: implement mbedtls support #660

Closed iameli closed 7 months ago

iameli commented 7 months ago

This was pretty easy; just porting over mbedtls support that was already added from https://github.com/cisco/libsrtp/pull/512. Now it works with Meson too!

pabuhler commented 7 months ago

@iameli I have no problem with merging these changes, although I do not know much about meson build. Since we moved to github actions for CI meson builds are no longer run regularly. Would you be interested in adding a git hub action for this ?

iameli commented 7 months ago

@pabuhler Done! Added a test that mirrors the CMake test — you can see it running successfully for a3c1688 over on my fork here https://github.com/iameli/srtp-ci-test/actions/runs/7108414189

pabuhler commented 7 months ago

@iameli awesome, I have merged this now. In general I dont think we will block merging changes when a meson build fails, but at least we will now know something needs to be done.