cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.19k stars 469 forks source link

ABI break in 2.6.0 #699

Closed bbhtt closed 2 months ago

bbhtt commented 2 months ago

Hi, I'm seeing an ABI break going from 2.5.0 to 2.6.0. Is either of this public API?

        ┌──────────────────────────┐
        │ ABI Break: libsrtp2.so.1 │
        └──────────────────────────┘
        Functions changes summary: 0 Removed, 1 Changed (18 filtered out), 0 Added functions
        Variables changes summary: 1 Removed, 0 Changed (3 filtered out), 0 Added variables
        1 function with some indirect sub-type change:
          [C] 'function srtp_session_keys_t* srtp_get_session_keys(srtp_stream_ctx_t*, uint8_t*, const unsigned int*, unsigned int*)' at srtp.c:1618:1 has some indirect sub-type changes:
            parameter 3 of type 'const unsigned int*' changed:
              entity changed from 'const unsigned int*' to 'unsigned int'
              type size changed from 64 to 32 (in bits)
        1 Removed variable:
          [D] 'srtp_stream_list_ctx_t_ srtp_stream_list_ctx_t_'    {srtp_stream_list_ctx_t_}

It seems to be coming from https://github.com/cisco/libsrtp/commit/120b51bf0e2b0485b48c893862690890accfd634

pabuhler commented 2 months ago

hi @bbhtt ,

Thank for reporting this, but neither of these are part of a public ABI api. Do these changes cause trouble for you?

bbhtt commented 2 months ago

If it is not a public API then it's fine and we can ignore the report and update.

Thanks for the reply.