cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.19k stars 469 forks source link

consider merging the gcm encrypt and get tag functions of cipher api #714

Open pabuhler opened 1 month ago

pabuhler commented 1 month ago

The gcm encryption is a one shot function, it is always only called only once. The tag is often generated at this point by the underling crypto engine (see aes_gcm_nss.c), it would be clear to append the tag to the out immediately instead of caching it. This would match the decrypt function.