search

cisco / libsrtp

Library for SRTP (Secure Realtime Transport Protocol)
Other
1.24k stars 476 forks source link

add test for ROC mіsmatch #725

Closed fippo closed 2 weeks ago

fippo commented 2 months ago

illustrating the reason why one should carefully pick the initial sequence number low enough to avoid a rollover.

See https://webrtc-review.googlesource.com/c/src/+/358360

fippo commented 2 months ago

Quite interesting that not everything fails... it fails when using OpenSSL but not in "normal" / builtin mode?! The reason for the failure is that the failed attempt to unprotect modifies pkt1 and pkt2 which is quite surprising.

Avoided by modifying the test slightly, see second commit.

pabuhler commented 2 weeks ago

@fippo Hi, I was curious why it failed with openssl, in the end it was not so exciting. When built with openssl the test uses the GCM cipher which does the decryption & authentication at the same time so it does not fail until it is complete. Will merge now and then work on adding support for trying ROC -1 when check new streams.

fippo commented 2 weeks ago

ah, that makes sense, thanks for figuring that out!