Once the PyTorch CRF PR gets merged, and we are good to make sure nothing fails, we can safely remove the dependency on CRFSuite and also remove/refactor the old CRFSuite code out of the mindmeld repo.
It would also make sense to rename the "torch-crf" as "crf" once it becomes the default CRF implementation.
Once the PyTorch CRF PR gets merged, and we are good to make sure nothing fails, we can safely remove the dependency on CRFSuite and also remove/refactor the old CRFSuite code out of the mindmeld repo. It would also make sense to rename the "torch-crf" as "crf" once it becomes the default CRF implementation.
This was mentioned as part of this PR discussion.