search

cisco / mindmeld

An Open Source Conversational AI Platform for Deep-Domain Voice Interfaces and Chatbots.
http://mindmeld.com
Apache License 2.0
677 stars 186 forks source link

Loosen marshmallow dependency #418

Closed jre21 closed 2 years ago

jre21 commented 2 years ago

The current dependency string only allows marshmallow 3.7.x versions. This change allows it to update to latest 3.x.

jre21 commented 2 years ago

I'm nixing this change. Two of our unit tests are only passing because of bugs in marshmallow's validator prior to 3.9.1 (it previously allowed serializations which should have been rejected). At this point I'm not willing to take a chance on that bug being load-bearing for more than just the unit tests.