Minor nits and fixing stuff related to PyTorch CRF - Githubissues

cisco / mindmeld

An Open Source Conversational AI Platform for Deep-Domain Voice Interfaces and Chatbots.

http://mindmeld.com

Apache License 2.0

677 stars 186 forks source link

Minor nits and fixing stuff related to PyTorch CRF #449

Closed vrdn-23 closed 2 years ago

vrdn-23 commented 2 years ago

This PR covers some things that provide minor fixes to some issues related to the PyTorch CRF.

Changes include:

Included the get_params() for torch-crf which I didn't implement the first time around
Set the current_params when loading the model, so that params are saved during save-params command in ANLP (h/t to @serapio for pointing this out)
Updated some doc strings
Made the temp file to save CRF path as a temporary context rather than as a class attribute.