cisco / mlspp

Implementation of Messaging Layer Security
BSD 2-Clause "Simplified" License
108 stars 41 forks source link

Convert tests to Catch2 #416

Closed bifurcation closed 9 months ago

bifurcation commented 9 months ago

As discussed in #415, doctest is broken and abandoned. Catch2 seems to be a more standard and more supported test framework. This PR converts MLSpp's tests from doctest to Catch2.

And for good measure, I went ahead and re-enabled tests on Windows. We'll see what happens in CI!

bifurcation commented 9 months ago

It turns out that what happens in CI is that the Windows tests still hang without SANITIZERS and blow up with it. The latter appears to be a known issue, since 2022. So I have re-disabled Windows tests. It looks like we're going to have to address the hang more directly.

I think it's still worthwhile to merge this PR, in order to get on a more supported testing framework.

bifurcation commented 9 months ago

Merging based on offline 👍 from @glhewett and @birarda

glhewett commented 9 months ago

Did you meant to comment out all of the tests? I guess not: #418