search

cisco / senml

Tool to convert senml between formats and act as gateway server to other services
BSD 2-Clause "Simplified" License
39 stars 15 forks source link

Fix CBOR data encoding #23

Closed dborovcanin closed 4 years ago

dborovcanin commented 4 years ago

For compactness, CBOR representation uses integers for labels, as described here. For that reason, SenML records are transformed to map[int]interface{} before encoding to CBOR.

dborovcanin commented 4 years ago

@fluffy Can you, please, review this PR?

dborovcanin commented 4 years ago

Closed due to inactivity.

fluffy commented 4 years ago

Probably Carsten is right person to review this but it looks about right to me. Why did you close it ?

dborovcanin commented 4 years ago

Probably Carsten is right person to review this but it looks about right to me. Why did you close it ?

@fluffy I closed this PR because I thought this repo is not maintained anymore. Also, we created a lightweight SenML lib because it was easier to maintain our code. Feel free to reopen, but the merge of #24 will resolve this issue. Also, please note that #23 is probably duplicate #2.