search

ciscoheat / buddy

Your friendly BDD testing library for Haxe!
MIT License
96 stars 24 forks source link

travis-hx support #26

Closed profelis closed 10 years ago

profelis commented 10 years ago

Hello.

I added console_log compiler flag, which turn on native flash/js trace.

All targets expect as3 works perfect, https://travis-ci.org/profelis/bindx2/builds/41169963. As3 target fail in promhx library (issue is open)

.travis.yml example file https://github.com/profelis/bindx2/blob/master/.travis.yml lines 18 and 58 are important

ciscoheat commented 10 years ago

Hi, thank you, your changes inspired me to modify ConsoleReporter and fix the problems with Sys once and for all. There's now a TraceReporter that fixes the general CI issues, and the TravisHxReporter inherits from that and adds the extra line needed. I think that should do it.

I made a little change to the Reporter interface to simplify things even more. It's not version 1.0 yet so I thought it was ok. :) @brendanjerwin you may also be affected by this if you've made a custom Reporter.

profelis commented 10 years ago

@ciscoheat you changes don't resolve problem with node.js. TraceReporter extends ConsoleReporter therefore js.Sys include in result. But js.Sys call window object, that expected in node.js.

https://travis-ci.org/profelis/bindx2/jobs/41168514#L419 - same problem

profelis commented 10 years ago

Hm, I was wrong, all perfect work https://travis-ci.org/profelis/bindx2/jobs/41221109 Seems like dce removed all unused code