ciscoheat / buddy

Your friendly BDD testing library for Haxe!
MIT License
96 stars 24 forks source link

Exit with 0 even tests failed? #49

Closed kevinresol closed 8 years ago

kevinresol commented 8 years ago

see: https://travis-ci.org/kevinresol/tink_remoting/jobs/126115012#L1772-L1775

ciscoheat commented 8 years ago

Problem with python, right? There might be some async problem I don't know about, it's a new target and I haven't done much python work really. I'll take a look. If you find something, let me know!

kevinresol commented 8 years ago

On python:

package;

import buddy.*;
using buddy.Should;

class Main extends SingleSuite
{
    public function new() {
        describe("Using Buddy", {
            var t = true;
            it("should be true", function(done){
                haxe.Timer.delay(function() {
                    t.should.be(false);
                    done();
                }, 6000);
            });
        });
    }
}

If the test fails due to timeout, the exit code is 0

ciscoheat commented 8 years ago

Thanks! That should be enough for a fix, I hope. :)

ciscoheat commented 8 years ago

Btw, what version of python are you using to run the tests?

kevinresol commented 8 years ago

@ciscoheat Python 3.5.1 (default, Jan 22 2016, 08:54:32)

ciscoheat commented 8 years ago

It was a quite simple fix, I think it should work now. The latest version is available on haxelib.

kevinresol commented 8 years ago

Yeah, works now. Thanks!

ciscoheat commented 8 years ago

Thanks for reporting. :)