search

ciscoheat / buddy

Your friendly BDD testing library for Haxe!
MIT License
96 stars 24 forks source link

Fix beforeAll() and afterAll() for haxe 4.0.0 rc 4 #80

Closed kLabz closed 5 years ago

kLabz commented 5 years ago

Using beforeAll(() -> { /* ... */ }) on haxe 4.0.0 rc 4 gives the following error: Unnamed lvalue functions are not supported.

kLabz commented 5 years ago

... and it only works for haxe 4, of course

kLabz commented 5 years ago

There's still some issues on CI.

Errors on 3.4.7 are not related to this PR and seem to be linked to https://github.com/back2dos/travix/issues/116

Errors on latest haxe seem to be related to some tink_* version mismatch, plus travix not being really ready for rc 4

ciscoheat commented 5 years ago

Thank you very much, will release a new haxelib version soon!

remiX- commented 5 years ago

@ciscoheat Can we have that new haxelib version pls 😋

remiX- commented 5 years ago

Ah... seems like afterEach needs same treatment :(

kLabz commented 5 years ago

Ah... seems like afterEach needs same treatment :(

I'll check all functions and make another PR

ciscoheat commented 5 years ago

@kLabz thanks, as soon as you've done that I'll release a new haxelib version!

ciscoheat commented 5 years ago

New version released (2.10.3)!