search

ciscoheat / mithril-hx

Haxe externs for Mithril (JS MVC framework)
181 stars 12 forks source link

Vnode state is no longer typed? #34

Closed hamaluik closed 5 years ago

hamaluik commented 5 years ago

Here https://github.com/ciscoheat/mithril-hx/commit/6739d34445fd063ff04362665c31f5f62d0b2b3a#diff-325ff780c8b003fccb2a4abb89c532a9R55-R56 you removed the generic on Vnode and turned it into a Dynamic for the vnode state. This removes static analysis and code completion, and it doesn't seem to have gained anything? Unless I'm missing something, can we bring the generic back?

ciscoheat commented 5 years ago

Hi, thanks for your feedback! Since I always used the Haxe-class based style of using Mithril, where the state is in the classes, I saw no need for the generic. But as you say, it does no harm so I'll restore it for version 2.1.

hamaluik commented 5 years ago

Awesome, thanks!

ciscoheat commented 5 years ago

It's back now, can you review if it's ok for you to use?

hamaluik commented 5 years ago

Will do when I have a chance, might be a couple days. Thanks!

hamaluik commented 5 years ago

Works great, thanks!

ciscoheat commented 5 years ago

Perfect, thanks for checking!