search

ciscorn / ldoce5viewer

⚠️ This software is no longer actively maintained -- Fast, free dictionary viewer for the Longman Dictionary of Contemporary English (LDOCE) 5th ed.
https://forward-backward.co.jp/ldoce5viewer/
Other
302 stars 127 forks source link

Migrated to Qt 6 with PySide6 to able run under arm macs #72

Closed akhoruzhenko closed 2 years ago

gifuhabu commented 2 years ago

@akhoruzhenko thanks for updating to PyQt6! I have built and tried the app on mac and windows but it cannot both seem to get the audio to play. Is this problem happening in your environment?

akhoruzhenko commented 2 years ago

Yes, this is known issue. I'm going to work with it this week.

akhoruzhenko commented 2 years ago

@gifuhabu try updated version, I fix bug with context menu in the page and now it can play audio

gifuhabu commented 2 years ago

@akhoruzhenko Thanks for fixing audio to play quickly. Now button to play works, but reloading word page by switching page or monitoring clipboard, it doesn't seem audio to play. (previous official build works) Do you have any idea to fix this?

akhoruzhenko commented 2 years ago

@gifuhabu if you talking about auto play feature when page opened then this issue next in list to fix. I'm working now to cleanup code and fix issue with auto play

akhoruzhenko commented 2 years ago

@gifuhabu fixed, you can check auto pronunciation now

gifuhabu commented 2 years ago

Thanks for fixing that! It works like charm. I found a bug that if you immediately switch to a page of words, the screen freezes and an exception occurs.

For example

Traceback (most recent call last):
  File "ldoce5viewer\qtgui\main.py", line 698, in _onClipboardChanged
AttributeError: 'MainWindow' object has no attribute 'isActiveWindow'. Did you mean: 'activateWindow'?
Traceback (most recent call last):
  File "ldoce5viewer\qtgui\main.py", line 698, in _onClipboardChanged
AttributeError: Slot 'MainWindow::_onUrlChanged(QUrl)' not found.

You can see that this occurs when you drag and drop against the word list in the sidebar. The official build works fine.

Also, the in-page search does not seem to be working.

JBraddockm commented 2 years ago

Thank you for the update. Is there a way you can share the final app as I am unable to build it from the source?