ciscorn / starlette-graphene3

An ASGI app for using Graphene v3 with Starlette / FastAPI
MIT License
101 stars 14 forks source link

Exceptions are not catched when using a websocket #17

Open pjotterplotter opened 3 years ago

pjotterplotter commented 3 years ago

It catches exceptions over http now https://github.com/ciscorn/starlette-graphene3/issues/13 is resolved, but it is still swallows exceptions when subscribing / sending the query over a websocket:

app.mount("/graphql", graphql_app) app.add_websocket_route("/graphql-ws", graphql_app)

Another suggestion would be to be able to mask the error details in the graphql response, so using logging getting the full error message, but return a generic error message over the graphql connection, so sensitive data cannot leak that way?