ciscorn / starlette-graphene3

An ASGI app for using Graphene v3 with Starlette / FastAPI
MIT License
101 stars 14 forks source link

Add connection parameters to the websocket scope #2

Closed abompard closed 3 years ago

abompard commented 3 years ago

The Apollo client supports a websocket authentication method by passing "connection parameters" to the client, that end up in the connection_init message.

This changeset makes those parameters available in the WebSocket request's scope.

codecov[bot] commented 3 years ago

Codecov Report

Merging #2 (ae328c5) into master (fdf34d0) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   89.23%   89.28%   +0.05%     
==========================================
  Files           1        1              
  Lines         195      196       +1     
==========================================
+ Hits          174      175       +1     
  Misses         21       21              
Flag Coverage Δ
unittests 89.28% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
starlette_graphene3.py 89.28% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdf34d0...ae328c5. Read the comment docs.

ciscorn commented 3 years ago

@abompard Great. Thanks!