citadel-tech / coinswap

Functioning, minimal-viable binaries and libraries to perform a trustless, p2p Maxwell-Belcher Coinswap Protocol
https://gist.github.com/chris-belcher/9144bd57a91c194e332fb5ca371d0964
Other
73 stars 46 forks source link

`bdk`: add `BDKError` into `WalletError` #209

Closed wthrajat closed 4 months ago

wthrajat commented 4 months ago

Aims to fix https://github.com/citadel-tech/coinswap/issues/202

KnowWhoami commented 4 months ago

It doesn't include BDKStore specific errors :

since we are only taking care of io::Error in WalletError which is relevant to BDKStore . IMO , there should be dedicated error enum for BDKStore which can take up all these specific errors. which must be included in BdkError.

mojoX911 commented 4 months ago

For now its okay to just put them in BdkError. If they become very large, we can take them out in a separate enum in future.

KnowWhoami commented 4 months ago

For now its okay to just put them in BdkError. If they become very large, we can take them out in a separate enum in future.

this is already solved in #178