Closed 007harshmahajan closed 3 months ago
There is another way to include build scripts in the crate, with more granular control for platform-specific compilation. Maybe that could be easier, and simpler for users of the lib, than features?
https://doc.rust-lang.org/cargo/reference/build-scripts.html
Not a block on this PR. Concept Ack. If this fixes the issue for mac compiling and testing, we should add it.
ACK. If possible, could you also address the CI/CD pipeline change related to https://github.com/citadel-tech/coinswap/pull/200
Will be good to get it included in this PR itself.
failing integration test when running on macos with cargo test --feature=integration-test-macos-aarch
failures:
---- src/lib.rs - (line 77) stdout ----
error: unknown start of token: `
--> src/lib.rs:85:47
|
11 | Play through a single test case, for example, `standard_swap`, by running:
| ^
|
help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
|
11 | Play through a single test case, for example, 'standard_swap`, by running:
| ~
error: unknown start of token: `
--> src/lib.rs:85:61
|
11 | Play through a single test case, for example, `standard_swap`, by running:
| ^
|
help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
|
11 | Play through a single test case, for example, `standard_swap', by running:
| ~
error: unknown start of token: `
--> src/lib.rs:87:1
|
13 | ```console
| ^^^
|
= note: character appears 2 more times
help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
|
13 | '''console
| ~~~
error: expected one of `!`, `.`, `::`, `;`, `?`, `{`, `}`, or an operator, found `test`
--> src/lib.rs:80:6
|
6 | Each test in the [tests](./tests/) folder covers a different edge-case situation and demonstrates how the taker and makers...
| ^^^^ expected one of 8 possible tokens
error: aborting due to 4 previous errors
Couldn't compile the test.
failures:
src/lib.rs - (line 77)
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.22s
error: doctest failed, to rerun pass `--doc`
build and integration test works on macos
coinswap on git macos_build [$!>] is pkg v0.1.0 via rs v1.80.0
> cargo build --features=integration-test-macos-aarch
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.51s
coinswap on git macos_build [$!>] is pkg v0.1.0 via rs v1.80.0
> cargo build --features=build-macos-aarch
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s
ACK. Can you remove the merge commit and rebase to master. We are good to go with this.
All good with sync with master, no need of rebase, no changes
https://app.warp.dev/block/g4mDqermk94xAvTH0GiaXi please once have a looks
adding of
tor
libs for macos build and cleaning README.md