Use Current Height as locktime to prevent `Fee-Snipping Attacks` - Githubissues

citadel-tech / coinswap

Functioning, minimal-viable binaries and libraries to perform a trustless, p2p Maxwell-Belcher Coinswap Protocol

https://gist.github.com/chris-belcher/9144bd57a91c194e332fb5ca371d0964

Other

73 stars 46 forks source link

Use Current Height as locktime to prevent `Fee-Snipping Attacks` #229

Closed KnowWhoami closed 2 months ago

KnowWhoami commented 3 months ago

For Fedility & normal transactions -> we are setting locktime as current height for preventing fee-snipping attack . https://github.com/citadel-tech/coinswap/blob/691c937454ccf1c2a182ef0aca1d514b7f74606d/src/wallet/fidelity.rs#L354
However, there is no locktime set for the funding and contract transactions, which is not ideal. These transactions are vital components of the protocol, and any attack on them could hinder the protocol's efficiency.

https://github.com/citadel-tech/coinswap/blob/691c937454ccf1c2a182ef0aca1d514b7f74606d/src/wallet/funding.rs#L177 https://github.com/citadel-tech/coinswap/blob/691c937454ccf1c2a182ef0aca1d514b7f74606d/src/protocol/contract.rs#L397

They also must have current-height as locktime to prevent this attack .