search

citadel-tech / coinswap

Functioning, minimal-viable binaries and libraries to perform a trustless, p2p Maxwell-Belcher Coinswap Protocol
https://gist.github.com/chris-belcher/9144bd57a91c194e332fb5ca371d0964
Other
73 stars 46 forks source link

Integration test: Multi-Taker And Single Maker Scenario #231

Open Shourya742 opened 3 months ago

Shourya742 commented 3 months ago

Add the behaviour for multiple taker to connect to a single chain of makers to perform swap. Use variety of taker behaviour to cover possible cases along with the standard happy path case.

Adds an integration test to simulate this whole situation.

mojoX911 commented 3 months ago

We can cover most of the surface, with this combination.

Maker: Normal Taker1: DropConnectionAfterFullSetup Taker2: BroadcastContractAfterFullSetup

These are the only two Taker behaviors we have. And both will force Maker to recover.

Later on, we can add more tests with other Maker behaviors.

In the long term, this can be a good approach to combinatorially cover all weird edge cases.

KnowWhoami commented 1 month ago

We can cover most of the surface, with this combination.

Maker: Normal Taker1: DropConnectionAfterFullSetup Taker2: BroadcastContractAfterFullSetup

Should we consider Normal behaviour of Taker in this test?

mojoX911 commented 2 days ago

Should we consider Normal behaviour of Taker in this test?

Yes.