search

citadel-tech / coinswap

Functioning, minimal-viable binaries and libraries to perform a trustless, p2p Maxwell-Belcher Coinswap Protocol
https://gist.github.com/chris-belcher/9144bd57a91c194e332fb5ca371d0964
Other
73 stars 46 forks source link

Check whether given amount is feasible to spend or not. #265

Closed KnowWhoami closed 1 month ago

KnowWhoami commented 2 months ago

Aims to solve 2nd Task of #264

mojoX911 commented 2 months ago

Ack. Looks good. LMK when its ready for review.

KnowWhoami commented 1 month ago

I have added one more test in the force push changes. There are some quick TODOs -> on which I need suggestions.

mojoX911 commented 1 month ago

Sorry its not an approve, but changes requested in the review.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (ac7a351) to head (54b9299). Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
src/wallet/direct_send.rs 54.16% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #265 +/- ## ========================================== - Coverage 80.54% 78.33% -2.21% ========================================== Files 26 30 +4 Lines 6230 6297 +67 ========================================== - Hits 5018 4933 -85 - Misses 1212 1364 +152 ``` | [Flag](https://app.codecov.io/gh/citadel-tech/coinswap/pull/265/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=citadel-tech) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/citadel-tech/coinswap/pull/265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=citadel-tech) | `78.33% <54.16%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=citadel-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.