citadel-tech / coinswap

Functioning, minimal-viable binaries and libraries to perform a trustless, p2p Maxwell-Belcher Coinswap Protocol
https://gist.github.com/chris-belcher/9144bd57a91c194e332fb5ca371d0964
Other
73 stars 46 forks source link

implement send_to_address #288

Open keraliss opened 3 weeks ago

keraliss commented 3 weeks ago

This pr attempts to implement send_to_address command for maker-cli

mojoX911 commented 2 weeks ago

@keraliss the code looks good. Let us know if you managed to run the command manually. Then we will merge this.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 75.62%. Comparing base (2f9f0aa) to head (1a5e1e8). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/maker/rpc/server.rs 0.00% 21 Missing :warning:
src/bin/maker-cli.rs 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #288 +/- ## ========================================== - Coverage 79.65% 75.62% -4.04% ========================================== Files 32 32 Lines 4945 4123 -822 ========================================== - Hits 3939 3118 -821 + Misses 1006 1005 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.