mojoX911
commented
1 week ago Ack. What are your thoughts on adding a NotFound error variant for all instances where we're currently using get with expect?
I am not entirely opposed. It feels equivalent to me. And more code to add variants just to denote a None, which is already a variant that we can match with an if let. So it's like writing let x = x;
If None needs to be handled we can already do that with if let matching.
Using expect basically says that "we never expect this to panic". And in rust we can somewhat claim such invariants if we architect the code correctly.
It can still panic, but that only means two things: We screwed up somewhere in our logic/Something very nasty happened at your computer (your memory wiped out).
Both are valid cases for just panics.
expect is a very useful pattern to easily handle "unexpected" Nones. If you need more complex None handling, you can always use if let on it.
KnowWhoami
codecov[bot]
Resolves #253, #237
Removes unwraps from
utill.rsandtakermodules.Note:
setup_loggerunwraps are kept intact. As this is only used once in cli apps, where unwraps atmain.rsit doesn't have any effect. We will later refator this anyway for custom logger. Wasn't worth to add one more error variants just for this.Added a few more unwraps removal from maker and market.