search

citadel-tech / coinswap

Functioning, minimal-viable binaries and libraries to perform a trustless, p2p Maxwell-Belcher Coinswap Protocol
https://gist.github.com/chris-belcher/9144bd57a91c194e332fb5ca371d0964
Other
73 stars 45 forks source link

Unintended Creation of Extra Directories when Starting CLI Binaries #298

Open KnowWhoami opened 2 weeks ago

KnowWhoami commented 2 weeks ago

For eg: whenever directoryd binary server is started -> 2 other directories named as maker , taker having debug.log file are created along with the expected directory one which is not a good UX design. This similar behaviour happens if we run makerd or taker cli app too.

Expected Outcome:

Only single directory with the required files must be created whose binary is being used.

mojoX911 commented 2 weeks ago

This is happening because of how the setup_logger function is unified for all the apps.

Solution: Use different setup_logger functions for different apps. For v0.1.0 this would be the quickest fix.

This will also be solved once we have our own custom logger.

KnowWhoami commented 1 week ago

So should we solve this issue after having our custom logger or fix it now? I think , we should fix it in v0.1.0 itself with the proposed solution otherwise these bugs will be exposed while running our cli-apps. What do you think?

mojoX911 commented 1 week ago

Ack on fixing it now with the quick fix. We need individual setup_logger functions for each apps.