search

citahub / cita-common

Libraries for CITA (https://github.com/citahub/cita)
Apache License 2.0
38 stars 34 forks source link

Add get release version from RPC #228

Closed luqz closed 5 years ago

kaikai1024 commented 5 years ago

can you work on this branch? https://github.com/cryptape/cita-common/pull/229

I will grant you permission.

kaikai1024 commented 5 years ago

bors try

bors[bot] commented 5 years ago

try

Timed out

kaikai1024 commented 5 years ago

Sorry. Still working on the circleci problem. weird, both you and @ouwenkg can not work. So, we will use travisCI temporarily。

kaikai1024 commented 5 years ago

You can drop tht test commit now. @luqz

kaikai1024 commented 5 years ago

And you can run the ci on your own repo if there are many pull requests. that's will faster to check the result

luqz commented 5 years ago

please drop the test commit

OK

codecov-io commented 5 years ago

Codecov Report

Merging #228 into develop will decrease coverage by 0.17%. The diff coverage is 20.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #228      +/-   ##
===========================================
- Coverage    49.29%   49.11%   -0.18%     
===========================================
  Files          115      116       +1     
  Lines        17244    17299      +55     
===========================================
- Hits          8501     8497       -4     
- Misses        8743     8802      +59
Impacted Files Coverage Δ
jsonrpc-proto/src/complete.rs 96.92% <ø> (-3.08%) :arrow_down:
jsonrpc-types/src/request/request.rs 94.73% <ø> (ø) :arrow_up:
jsonrpc-types/src/rpctypes/mod.rs 100% <ø> (ø) :arrow_up:
libproto/src/protos/response.rs 8.06% <0%> (-0.36%) :arrow_down:
libproto/src/protos/request.rs 3.65% <0%> (-0.17%) :arrow_down:
jsonrpc-types/src/request/tests/params.rs 100% <100%> (ø) :arrow_up:
jsonrpc-types/src/rpctypes/software_version.rs 100% <100%> (ø)
libproto/src/router.rs 78.82% <50%> (-0.94%) :arrow_down:
jsonrpc-types/src/rpctypes/block_number.rs 93.22% <0%> (-5.09%) :arrow_down:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39839cc...6c55bad. Read the comment docs.

leeyr338 commented 5 years ago

Plz do not using push -f every time. You need to have a new commit while you are changing the code, so I can know what you have changed for every commit. Otherwise, I must review the code from begin to end time after time.

kaikai1024 commented 5 years ago

Plz do not using push -f every time. You need to have a new commit while you are changing the code, so I can know what you have changed for every commit. Otherwise, I must review the code from begin to end time after time.

That's the right operation. you can click the force-push, and can read the changes

kaikai1024 commented 5 years ago

You need to have a new commit while you are changing the code

That's not a good choice for me.

leeyr338 commented 5 years ago

Plz do not using push -f every time. You need to have a new commit while you are changing the code, so I can know what you have changed for every commit. Otherwise, I must review the code from begin to end time after time.

That's the right operation. you can click the force-push, and can read the changes

That sounds OK.