search

citahub / cita_trie

Rust implementation of the Modified Patricia Tree (aka Trie).
Apache License 2.0
71 stars 28 forks source link

fix(trie): replace old node when deleted #8

Closed yejiayu closed 5 years ago

yejiayu commented 5 years ago

fix #5

yangby-cryptape commented 5 years ago

IMHO, I think here still require a modification: https://github.com/cryptape/cita-trie/blob/f649eb1fa0068c6871e3a8cdeb0c542e5b1a8714/src/trie.rs#L176-L179

And, I really doubt that the tests can works? https://github.com/cryptape/cita-trie/blob/f649eb1fa0068c6871e3a8cdeb0c542e5b1a8714/src/trie.rs#L527-L529 I'm not so sure, so, maybe you can add more reviewers to help us to figure it out.

yejiayu commented 5 years ago

Can you say more in detail? Where is the problem?