citation-file-format / cff-initializer-javascript

Web form to initialize CITATION.cff files.
https://citation-file-format.github.io/cff-initializer-javascript/
Apache License 2.0
21 stars 8 forks source link

Create screen for extra CFF fields #827

Closed abelsiqueira closed 1 year ago

abelsiqueira commented 1 year ago

Pull request details

As a contributor I confirm

List of related issues or pull requests

Refs:

Describe the changes made in this pull request

Add screen that captures extra fields. Fields are input as string and parsed with YAML. Errors are displayed - both from YAML and from validation. Validation is not captured, so errors are raw.

Instructions to review the pull request

github-actions[bot] commented 1 year ago

Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR827/

github-actions[bot] commented 1 year ago

Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR827/

codecov-commenter commented 1 year ago

Codecov Report

Merging #827 (e13d335) into main (53060af) will increase coverage by 1.87%. The diff coverage is 58.82%.

@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   15.76%   17.64%   +1.87%     
==========================================
  Files          37       39       +2     
  Lines         723      765      +42     
  Branches       82       89       +7     
==========================================
+ Hits          114      135      +21     
- Misses        609      630      +21     
Impacted Files Coverage Δ
src/components/RawErrorList.vue 0.00% <0.00%> (ø)
src/components/ScreenExtraCffFields.vue 0.00% <0.00%> (ø)
src/error-filtering.ts 0.00% <ø> (ø)
src/router/routes.ts 0.00% <0.00%> (ø)
src/store/app.ts 74.46% <ø> (ø)
src/store/stepper-errors.ts 0.00% <0.00%> (ø)
src/store/validation.ts 87.17% <82.75%> (-12.83%) :arrow_down:
src/store/cff.ts 100.00% <100.00%> (ø)
src/store/cffstr.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

Once the build has completed, you can preview your PR at this URL: https://cffinit.netlify.app/PR827/