Orcid api

[c-martinez]

Pull request details

Adds author information from ORCID API, when orcid field is filled. I'm sure it is not the most elegant solution, but it works and that is a good start. Suggestions for improvement are welcome.

As a contributor I confirm

• [ ] I read and followed the instructions in CONTRIBUTING.md
• [ ] The developer documentation is up to date with the changes introduced in this Pull Request
• [ ] Tests are passing
• [ ] All the workflows are passing

List of related issues or pull requests

Refs:

• 639

• 688

Describe the changes made in this pull request

Instructions to review the pull request

[abelsiqueira]

Hi @c-martinez, I appreciate the update on the PR. After rebasing and testing, it seems that everything is working fine. However, I have a few suggestions to improve the code further:

• It would be great if you could rebase into the newer main as there are conflicts that may have caused the tests not to run correctly.
• Running npm run dev throws various warnings and errors, mainly from the linter. Could you kindly take a look at those and fix them?
• To make it clear that users can import from ORCID, we should add a button, either on the top or on the side of the ORCID field. I'm not sure which would be better.
• We need a way to provide positive and negative feedback, maybe by using $q.notify as shown in Preview.vue.
• We should also add some tests to Cypress. Perhaps a separate test to verify that the workflow is functional would suffice.

Please let me know if you need any further input from me.

[c-martinez]

Hey @abelsiqueira, thanks for your feedback. I'm making a little checklist for myself, I'll do as much as I can, but I think there might be a couple of things where I will need help (javascript is not my strongest language):

• [x] Rebase to newer main

• [x] Run tests correctly

• [x] Fix linter errors from npm run dev

  I tried to fix most of these, but some I just had no idea how to fix. HELP!

• [x] Add a button on top or side of ORCID field

  Added some text on the top button, although I wasn't sure how to style the text (I wanted to add the text in a new line, with TIP on bold).

• [x] Provide positive and negative feedback, maybe by using $q.notify as shown in Preview.vue.

  Added positive feedback. Not sure where the negative feedback would need to be provided.

• [ ] We should also add some tests to Cypress

  Not very sure how to do these last two (not familiar at all with Cypress).